search

hubmapconsortium / commons

The common code supporting the HuBMAP web services
MIT License
1 stars 0 forks source link

Deprecate `TypeClient` #114

Closed yuanzhou closed 1 month ago

yuanzhou commented 12 months ago

https://github.com/hubmapconsortium/commons/blob/main/hubmap_commons/type_client.py is being used by the following repos:

As we move to the direct UBKG ontology-api calls for the assay type lookups, corresponding plans should be made in each repo to minimize the impact.

yuanzhou commented 6 months ago

From Zhou:

I still see the code being used: https://github.com/search?q=repo%3Ahubmapconsortium%2Fingest-pipeline+TypeClient&type=code and once we remove the TypeClient from commons, will the ingest-pipeline error out?

From Sunset:

no, it won't. that's piece of code is never used and will be pruned at some point

yuanzhou commented 6 months ago

FYI @lchoy and @john-conroy, according to @jpuerto-psc, your team will need to take care of the UTA code changes.

yuanzhou commented 1 month ago

With John's recent work in search-api https://github.com/hubmapconsortium/search-api/pull/830, we'll be able to fully deprecate this TypeClient and remove it from commons very soon.

yuanzhou commented 1 month ago

I reopened the https://github.com/hubmapconsortium/ingest-pipeline/issues/837 since the TypeClient is still in the code.

yuanzhou commented 1 month ago

7/24/2024, got the word from @sunset666 that we can go ahead and remove the TypeClient from the commons.