search

hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities
https://entity.api.hubmapconsortium.org
MIT License
3 stars 1 forks source link

Reapplying fix (json_data_dict -> json_data_dict_list[i]) in exceptio… #554

Closed DerekFurstPitt closed 9 months ago

DerekFurstPitt commented 9 months ago

Reapplying fix (json_data_dict -> json_data_dict_list[i]) in exception. Fix was unintentionally removed when re-adding exceptions

DerekFurstPitt commented 9 months ago

Initially, this error was identified and when I fixed it, I fixed it in 2 places it occurred, once at the top of the function, and once lower down just after generated_before_create_trigger_data_dict. It was brought to my attention that some of these exceptions were unnecessary because they only applied to other entity types. So I removed these exceptions. This was premature as it turned out only the first block needed removed, the second block could come in handy. But when I re-added the second exception block, I mistakenly omitted the original fix. This re-applies that fix.