search

hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities
https://entity.api.hubmapconsortium.org
MIT License
3 stars 1 forks source link

Derek furst/update derived queries #559

Closed DerekFurstPitt closed 11 months ago

DerekFurstPitt commented 11 months ago

Changed dataset_is_primary to use creation_action to determine whether a dataset is primary rather than inspecting its distance from the nearest sample ancestor

yuanzhou commented 11 months ago

@DerekFurstPitt The query updates handle the "Central Process" and "Lab Process" Activity types. Do we need to exclude the "Multi-Assay Split" type as well for those component datasets?

DerekFurstPitt commented 11 months ago

@DerekFurstPitt The query updates handle the "Central Process" and "Lab Process" Activity types. Do we need to exclude the "Multi-Assay Split" type as well for those component datasets?

I am uncertain. Issue 534 only says lab process and central process, and the example query bill included specifically uses the "ends with process" bit

yuanzhou commented 11 months ago

From Bill:

The result of a “Multi-Assay Split” dataset isn’t a derived/processed dataset so should not be included in this task.