hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities

https://entity.api.hubmapconsortium.org

MIT License

3 stars 1 forks source link

Add Dataset Activity.creation_action to ENTITY.Dataset as creation_action_activity #574

Closed ChuckKollar closed 7 months ago

ChuckKollar commented 7 months ago

Issue https://github.com/hubmapconsortium/entity-api/issues/551

DerekFurstPitt commented 7 months ago

@shirey That was my thinking as well reading through this. If we still want this property to remain transient (for datasets) but want it to be returned on a GET request, I think an on-read trigger would suffice and wouldn't necessitate creating another transient property.

ChuckKollar commented 7 months ago

OK! Great! Thanks for the suggestions and the read over! :-) I'm assuming that the current work satisfies Bill's change request.

ChuckKollar commented 7 months ago

This PR did contain the addition of the following code in src/instance/app.cfg.example

URL for talking to Ontology API (default for DEV)

Works regardless of the trailing slash

ONTOLOGY_API_URL = 'https://ontology-api.dev.hubmapconsortium.org'

But Joe wanted it removed, so I did.