hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities
https://entity.api.hubmapconsortium.org
MIT License
3 stars 1 forks source link

`dataset_type` of `CODEX [Cytokit + SPRM]` not accepted #586

Closed shirey closed 9 months ago

shirey commented 9 months ago

Testing on both DEV and TEST creating (POSTing) a new Dataset with the following input failed. The value "dataset_type":"CODEX [Cytocit + SPRM]" is a valid dataset_type following the rule that anything matching "valid_dataset_type_value [*]" is valid.

Input/Request

{
  "lab_dataset_id": "test-derived-codex-dataset",
  "contains_human_genetic_sequences": false,
  "data_types": [
    "codex_cytokit_v1"
  ],
  "dataset_type": "CODEX  [Cytokit + SPRM]",
  "direct_ancestor_uuids": [
    "d0ebafcbe06c9fa2cb739c4a860e79bd"
  ],
  "group_uuid": "5bd084c8-edc2-11e8-802f-0e368f3075e8",
  "description": "Bill Test Dataset",
  "creation_action": "Central Process"
}

Response/returned error:

{
  "error": "400 Bad Request: Proposed Dataset dataset_type 'CODEX [Cytokit + SPRM]' is not recognized in the existing ontology. Valid values are: ['Histology', 'Molecular Cartography', 'RNASeq', 'ATACSeq', 'SNARE-seq2', 'PhenoCycler', 'CyCIF', 'MERFISH', 'MALDI', '2D Imaging Mass Cytometry', 'nanoSPLITS', 'Auto-fluorescence', 'Confocal', 'Thick section Multiphoton MxIF', 'Second Harmonic Generation (SHG)', 'Enhanced Stimulated Raman Spectroscopy (SRS)', 'SIMS', 'Cell DIVE', 'CODEX', 'Lightsheet', 'MIBI', 'LC-MS', 'DESI', '10x Multiome', 'Visium']."
}
shirey commented 9 months ago

Closing. This was because of multiple spaces between the primary dataset specifier CODEX and the bracketed pipeline specifier for the processed/derived type [Cytokit + SPRM]