Move `display_subtype` logic from search-api to entity-api - Githubissues

hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities

https://entity.api.hubmapconsortium.org

MIT License

3 stars 1 forks source link

Move `display_subtype` logic from search-api to entity-api #631

Closed yuanzhou closed 2 months ago

yuanzhou commented 4 months ago

Currently this display_subtype field gets calculated in the search-api during indexing runtime for each entity (except Collection). By moving the logic to entity-api, we'll be able to take advantage of entity caching thus reduce the number of unnecessary calculations.

AFTER implementing the new featured described in #630, add a new field display_subtype in schema yaml based on the following rules:

Donor: fixed value "Donor"
Upload: fixed value "Data Upload"
Dataset/Publication: generated by on_index_trigger from dataset_type value
Sample: generated by on_index_trigger. When sample_category == "organ", use organ code. Otherwise, capitalize('sample_category')

shirey commented 2 months ago

Won't do this, as it will cause unforeseen downstream issues