search

hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities
https://entity.api.hubmapconsortium.org
MIT License
3 stars 1 forks source link

New `Upload/Dataset/Publication.status` allowable value `Incomplete` #634

Closed shirey closed 3 months ago

shirey commented 4 months ago

Add the new allowable status value of Incomplete for Dataset.status, Publication.status and Upload.status along with the all the existing status allowable values for those entities. It looks like the change for Dataset should affect Publication too, as Publication inherits from Dataset, butUpload` will need to be handled separately.

yuanzhou commented 4 months ago

@ChuckKollar I think there are only two places to support this new status:

Dataset/Publication: https://github.com/hubmapconsortium/entity-api/blob/51949247876c8c84077a6ce62e8d3b5933d4ba79/src/schema/schema_validators.py#L281-L283

Also update the schema yaml description: https://github.com/hubmapconsortium/entity-api/blob/51949247876c8c84077a6ce62e8d3b5933d4ba79/src/schema/provenance_schema.yaml#L315

Upload: https://github.com/hubmapconsortium/entity-api/blob/78c7d1a1a74f97931264684341d9a31aa94764c1/src/schema/schema_validators.py#L457-L459

https://github.com/hubmapconsortium/entity-api/blob/78c7d1a1a74f97931264684341d9a31aa94764c1/src/schema/provenance_schema.yaml#L934

ChuckKollar commented 4 months ago

Let Jes know when this goes to DEV.

ChuckKollar commented 4 months ago

PR: https://github.com/hubmapconsortium/entity-api/pull/637