hubmapconsortium / entity-api

A set of web service calls to return information about HuBMAP entities
https://entity.api.hubmapconsortium.org
MIT License
3 stars 1 forks source link

Add attributes to track existing component datasets after conversion to Multi-Assay #635

Closed shirey closed 3 months ago

shirey commented 4 months ago

Add two new attributes to Dataset which will be used to track Multi-Assay datasets that are constructed from existing data:

These new attributes will allow tracking of old existing, processed datasets that are associated with newly created Multi-Assay datasets. Instead of creating a link/edge in Neo4j we will just store ids in the associated datasets. This will allow us to track the links shown in yellow in the drawing at the top of Multi-Assay Reorg

image

kburke commented 4 months ago

@shirey Should trigger methods do the following?

Also, Multi-Assay Datasets can only be POSTed, with all of the component Datasets specified? There is no notion of PUTting later, particularly to add or delete component Datasets?

kburke commented 4 months ago

Per Bill's feedback, I will make sure the Dataset POSTed does not specify both superseded_associated_processed_component_uuids and new_associated_multi_assay_uuid, but will not navigate submitted UUIDs for deeper verification at this time.

I will limit setting superseded_associated_processed_component_uuids to POST call which create a Multi-Assay Dataset, and reject any PUT that modifies it.

POST and PUT calls which set new_associated_multi_assay_uuid will only be allowed when new_associated_multi_assay_uuid and superseded_associated_processed_component_uuids are not set.