hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
MIT License
4 stars 2 forks source link

Nx and angular upgrade #324

Closed axdanbol closed 7 months ago

nx-cloud[bot] commented 7 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0ecdf80d511a8c71b4fca08c0e5f1a36d8b54def. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets - [`nx affected --targets=compodoc --configuration=ci`](https://cloud.nx.app/runs/aEaeaS6ysK?utm_source=pull-request&utm_medium=comment) - [`nx affected --targets=build --configuration=preview`](https://cloud.nx.app/runs/yo74Tucpdm?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 7 months ago

:rocket: Preview Deploy Report Updated

✅ Successfully deployed preview here

bherr2 commented 7 months ago

Link styling color is off. Also seeing some errors in the console:

Cell Summary not found in data: https://purl.humanatlas.io/2d-ftu/kidney-thick-ascending-loop-of-henle [main.js:1:581617](https://65a18d321e61a3342def5623--hra-ui.netlify.app/apps/ftu-ui-small-wc/main.js)
Iri not found in data: https://purl.humanatlas.io/2d-ftu/kidney-thick-ascending-loop-of-henle
axdanbol commented 7 months ago

Link styling color is off. Also seeing some errors in the console:

Cell Summary not found in data: https://purl.humanatlas.io/2d-ftu/kidney-thick-ascending-loop-of-henle [main.js:1:581617](https://65a18d321e61a3342def5623--hra-ui.netlify.app/apps/ftu-ui-small-wc/main.js)
Iri not found in data: https://purl.humanatlas.io/2d-ftu/kidney-thick-ascending-loop-of-henle

@bherr2 So the errors are because the data files in assets/TEMP does not contain associated data. Should I rerun ftu-data.mjs?

bherr2 commented 7 months ago

Is that the only ftu with the error?

axdanbol commented 7 months ago

No, a lot of them have the same error. Currently only 7 items exists in the data files.

[
    "https://purl.humanatlas.io/2d-ftu/kidney-nephron",
    "https://purl.humanatlas.io/2d-ftu/kidney-renal-corpuscle",
    "https://purl.humanatlas.io/2d-ftu/kidney-cortical-collecting-duct",
    "https://purl.humanatlas.io/2d-ftu/kidney-ascending-thin-loop-of-henle",
    "https://purl.humanatlas.io/2d-ftu/lung-bronchial-submucosal-gland",
    "https://purl.humanatlas.io/2d-ftu/lung-pulmonary-alveolus",
    "https://purl.humanatlas.io/2d-ftu/liver-liver-lobule"
]
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.1% Duplication on New Code

See analysis details on SonarCloud