search

hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
https://hubmapconsortium.github.io/hra-ui/
MIT License
3 stars 2 forks source link

Appearance discrepancy in CTA button #452

Closed LibbyUX closed 1 week ago

LibbyUX commented 2 weeks ago

Appearance discrepancy in CTA button

The call to action button has rounded corners in https://apps.humanatlas.io/dashboard. This button's font-weight and letter spacing could also be closer to the specification.

Production

image

Spec

image

Design System

Please see the CTA button component in the Design System Repository.

image

bhushankhope commented 2 weeks ago

@LibbyUX the spec for the 'Read Paper' button is different than the main 'Button' in the design system. I have used the styles of 'Read Paper' button. I will update the styles to use the main button styles. Thank you.

image
LibbyUX commented 2 weeks ago

@bhushankhope thank you so much! The font sizes have been a moving target this cycle. Last week I adjusted the font size from 18px to 16px in the design system. Thank you for noting this was not yet updated in the Dashboards file! I just refreshed it with the design system repo updates, so you should see those changes in Dashboards now.

Yes, please ping me when the button corner radius' and the label font styles match the spec exactly! There might be more tinkering and we might need to sit together to finalize the font styles in production. Thanks so much for looking into this!

bhushankhope commented 2 weeks ago

@LibbyUX fixed in pr #468