hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
https://hubmapconsortium.github.io/hra-ui/
MIT License
3 stars 2 forks source link

Cde landing page updates #484

Closed edlu77 closed 4 days ago

edlu77 commented 1 week ago

470

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c2e5bf6293de901d02c00f86ccf2ba03e822a728. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx affected --target=build --parallel=3`](https://cloud.nx.app/runs/fNmRY9PihN?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage`](https://cloud.nx.app/runs/bJI1vpVVmx?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/7dIUmepRZe?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test-doc-coverage --parallel=3`](https://cloud.nx.app/runs/mFIT64l5Tl?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx format:check`](https://cloud.nx.app/runs/P4PDFjY6eD?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=*,!tag:karma-test-runner --code-coverage`](https://cloud.nx.app/runs/i4yO9Ov7zb?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 1 week ago

:rocket: Preview Deploy Report Updated

✅ Successfully deployed preview here

bherr2 commented 1 week ago

@edlu77 pull from develop and fix the footer conflicts (the old cde-ui footer component should be removed)

sonarcloud[bot] commented 4 days ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

LibbyUX commented 4 days ago

Once @LibbyUX signs off, the code looks fine, so I'll merge once she approves.

@bherr2 & @edlu77 - This is great! Thanks so much!

LibbyUX commented 4 days ago

Hey @bherr2 & @edlu77 - I just noticed something that caught my eye:

The footer is not centered in this preview: https://667ec9f250c3bc30798726e9--hra-ui.netlify.app/apps/cde-ui/

image

LibbyUX commented 4 days ago

I updated the +1920px node in Figma so it stays centered when the width is larger than 1920px: https://www.figma.com/design/G0xVFFsAAnBwzHd8PtQEeb/Cell-Distance-Explorer?node-id=2147-11964&t=6a8Dh3qYfZTLUTYa-4

I will work on a more intuitive/responsive solution for our design system footer, as well, so we can move away from 9 different breakpoints for all the components