Closed edlu77 closed 4 days ago
CI is running/has finished running commands for commit c2e5bf6293de901d02c00f86ccf2ba03e822a728. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.
📂 See all runs for this CI Pipeline Execution
Sent with 💌 from NxCloud.
✅ Successfully deployed preview here
@edlu77 pull from develop and fix the footer conflicts (the old cde-ui footer component should be removed)
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Once @LibbyUX signs off, the code looks fine, so I'll merge once she approves.
@bherr2 & @edlu77 - This is great! Thanks so much!
Hey @bherr2 & @edlu77 - I just noticed something that caught my eye:
The footer is not centered in this preview: https://667ec9f250c3bc30798726e9--hra-ui.netlify.app/apps/cde-ui/
I updated the +1920px node in Figma so it stays centered when the width is larger than 1920px: https://www.figma.com/design/G0xVFFsAAnBwzHd8PtQEeb/Cell-Distance-Explorer?node-id=2147-11964&t=6a8Dh3qYfZTLUTYa-4
I will work on a more intuitive/responsive solution for our design system footer, as well, so we can move away from 9 different breakpoints for all the components
470