hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
https://hubmapconsortium.github.io/hra-ui/
MIT License
3 stars 2 forks source link

add base href to dashboard-ui #495

Open bhushankhope opened 6 days ago

bhushankhope commented 6 days ago

Added base href to dashboard

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nx-cloud[bot] commented 6 days ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 92ec48b28ccb73385c984997c554c978e4bd9971. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx affected --target=build --parallel=3`](https://cloud.nx.app/runs/z681UGIZoG?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage`](https://cloud.nx.app/runs/sU8TKFRC1L?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/9rsAWH3cmi?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx format:check`](https://cloud.nx.app/runs/L1ubN7JIUc?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=*,!tag:karma-test-runner --code-coverage`](https://cloud.nx.app/runs/bVIGudU2KC?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test-doc-coverage --parallel=3`](https://cloud.nx.app/runs/y7wwbDdW1L?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 6 days ago

:rocket: Preview Deploy Report

✅ Successfully deployed preview here

bherr2 commented 6 days ago

Let's wait for @axdanbol to get back on Monday. I'm sure he'll have a great solution for this and probably best to wait until he can weigh in.

bherr2 commented 1 day ago

@axdanbol we'd like you to try your hand at resolving the base-href issue. I see we use base-href for both routes and assets. I believe we will need to separate how we think about them in order to make this work well for web components / apps that are served from CDN, but need nice route URLs at the deployment site. I'm thinking we let the base-href from html determine the route URL resolution (essentially no change in that area) whereas an input/web component attribute (app-href?) determines the base application href for assets that are delivered next to the application files on CDN.