hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
MIT License
4 stars 2 forks source link

Bug(ccf-rui): Organ input should accept an iri #569

Open axdanbol opened 2 months ago

axdanbol commented 2 months ago

Expected

It should be possible to pass an iri as the organ, ex:

Actual

No organ is selected

Cause

The comparison between the entity label and organ name in reference-data.state.ts:181 is case sensitive preventing the correct organ from matching.

bherr2 commented 2 months ago

We already have support for them selecting by ontologyId (the uberon term for kidney for instance) plus sex and side. Doesn't that still work? See https://github.com/hubmapconsortium/hra-ui/blob/develop/apps/ccf-rui/src/app/core/store/model/model.state.ts#L531 . If it doesn't work, we need to fix it.

I'm hesitant to have people set the reference organ IRIs as they change fairly frequently and would require them to use string manipulation to create if they were trying to change sex / side. One case where it might make sense is when editing existing registrations, BUT the RUI should automatically switch to the right organ anyway (if not, that's a bug).