search

hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
MIT License
4 stars 2 forks source link

Bug Report: Correct Organ Does Not Turn On Automatically in EUI #595

Open danqaurooni opened 2 months ago

danqaurooni commented 2 months ago

This is a bug report about the EUI. When opening a custom, organ-specific registration set, the expected behavior is for the EUI to turn on the skin plus the correct organ, which is the organ that contains actual tissue blocks in the current registration set. This fails to happen.

For example, the link below is a pancreas-specific registration set so the correct organ to turn on would be the pancreas, but this fails to happen: https://hubmapconsortium.github.io/hra-registrations/staging/hubmap-pancreas-campbell-2024/

This is becoming more confusing as we are preparing more and more organ-specific registration sets that outsiders use in their presentations.

OS: MacOS Browser: Chrome

bherr2 commented 2 months ago

There has never been a feature to automatically turn on the 'right' organs. That said, we do have an option in the html code to turn on specific organs with the 'selected-organs' attribute. I'll see if I can write an example for you for the pancreas case in particular.

It would be worth considering adding something like this, but it'd need to be thought through a bit. There are some considerations on what to show, especially if there are a lot of relevant organs. Do you show them all? No, the 3d models are too bulky and would slow down the browser and have a ton of overlap. Do you pick the top n organs by tissue block count? Maybe, but doesn't guarantee a legible 3d view.

CC @LibbyUX