hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
MIT License
4 stars 2 forks source link

24 hr event page updates #810

Closed edlu77 closed 1 week ago

nx-cloud[bot] commented 2 weeks ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03259d9cdb28d34b5d0344411eb8619065fe85a4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx affected --target=build --parallel=3`](https://cloud.nx.app/runs/QriURkG8uN?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage`](https://cloud.nx.app/runs/Au1PHhAG1H?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/7Bq19YfjVb?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx format:check`](https://cloud.nx.app/runs/7nqgScTJ23?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test-doc-coverage --parallel=3`](https://cloud.nx.app/runs/u5VWfqzQpF?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=*,!tag:karma-test-runner --code-coverage`](https://cloud.nx.app/runs/8RDReDwYdN?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 2 weeks ago

:rocket: Preview Deploy Report Updated

✅ Successfully deployed preview here

LibbyUX commented 2 weeks ago

Good morning @bherr2 & @edlu77, thanks for making this happen so quickly!

I see Katy wants to review this now per the ongoing email thread. I'm going to wait to approve these changes until we have her approval.

Can one of you please send me the URL to this preview page? I am having trouble locating it after going to the HRA Portal and the old event page from 2022. I'd like to share it with her, if possible. Thanks!

LibbyUX commented 2 weeks ago

Hi @edlu77, I have a request for this UI now that I see it here: https://67330a328fc5ee75aae666e2--hra-ui.netlify.app/apps/humanatlas.io/events/2024-24h/

Is it possible to remove the borders for the images? I believe it would look better and be more on brand without the borders/strokes around the circular images.

image

edlu77 commented 2 weeks ago

@LibbyUX Border has been removed! Let me know if anything else comes up.

edlu77 commented 2 weeks ago

@LibbyUX Link to new preview: https://673397be06b89f20f5809721--hra-ui.netlify.app/apps/humanatlas.io/events/2024-24h/

(For future reference you can access the page if you add "events/2024-24h" at the end of the preview url)

LibbyUX commented 2 weeks ago

@edlu77 Thanks so much - It looks great on my end! This design/build is likely going to be more iterative with the content still being situated. I emailed Katy/team with the preview link and image board tonight making sure to CC you. Talk soon and have a lovely evening!

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud