hubmapconsortium / hra-ui

HRA UIs Monorepo (includes HRA Portal, EUI, RUI, ASCT+B Reporter, and more)
MIT License
4 stars 2 forks source link

Edge generator CLI #828

Closed axdanbol closed 1 week ago

nx-cloud[bot] commented 1 week ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7c85c8b5046172331f0a96864be943abe9c638fd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets - [`nx affected --target=test --parallel=3 --exclude=tag:karma-test-runner --ci --code-coverage`](https://cloud.nx.app/runs/YVAfui5sF9?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=build --parallel=3`](https://cloud.nx.app/runs/VXtoXhndNN?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=lint --parallel=3`](https://cloud.nx.app/runs/71uERd0Cii?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test-doc-coverage --parallel=3`](https://cloud.nx.app/runs/FI1jIIxxTT?utm_source=pull-request&utm_medium=comment) - [`nx affected --target=test --parallel=3 --exclude=*,!tag:karma-test-runner --code-coverage`](https://cloud.nx.app/runs/vjMVtynVKq?utm_source=pull-request&utm_medium=comment) - [`nx-cloud record -- npx nx format:check`](https://cloud.nx.app/runs/2tFFXEOXVB?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

github-actions[bot] commented 1 week ago

:rocket: Preview Deploy Report Updated

✅ Successfully deployed preview here

bherr2 commented 1 week ago

Looks pretty good. A couple of minor things:

  1. Add a shebang to the generated cli.js and mark as executable. See how I did it before here: https://github.com/x-atlas-consortia/hra-api/blob/main/scripts/build.js#L26. Later when publishing, this will allow the cli to be put into the bin path like this: https://github.com/x-atlas-consortia/hra-api/blob/main/package.json#L14-L16.
  2. Add option to set the output file name. Most of the time cli.js is probably fine, but should allow them to override using the same name with a new one.
sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud