search

hubmapconsortium / hubmap-api-py-client

Python client for the Cells API
MIT License
1 stars 0 forks source link

Should dataset be UUID instead of integer? #13

Closed mccalluc closed 3 years ago

mccalluc commented 3 years ago

I'm expecting to see a UUID here instead of "19".

>>> from cells_api_py_client import Client
>>> client = Client('https://cells.dev.hubmapconsortium.org/api/')
>>> clusters_with_gene = client.select_clusters(where='gene', has='CASTOR2')
>>> clusters_with_gene.get_list(10)[0]
{'cluster_method': 'leiden', 'cluster_data': 'UMAP', 'grouping_name': '2', 'dataset': 19}
SFD5311 commented 3 years ago

Yes, this definitely should be a UUID. This will be resolved shortly. I'll follow up on here when it is.

SFD5311 commented 3 years ago

Should be fixed with commit: https://github.com/hubmapconsortium/cross_modality_query/commit/841a5bcf3b62544e5614dbc607da75c2386b65d0

mccalluc commented 3 years ago

Looks good now. Thanks!

>>> from cells_api_py_client import Client
>>> client = Client('https://cells.dev.hubmapconsortium.org/api/')
>>> clusters_with_gene = client.select_clusters(where='gene', has='CASTOR2')
>>> clusters_with_gene.get_list(10)[0]
{'cluster_method': 'leiden', 'cluster_data': 'UMAP', 'grouping_name': '2', 'dataset': '0576b972e074074b4c51a61c3d17a6e3'}