search

hubmapconsortium / hubmap-api-py-client

Python client for the Cells API
MIT License
1 stars 0 forks source link

Sfd5311/new dataset queries #64

Closed SFD5311 closed 3 years ago

SFD5311 commented 3 years ago

@mccalluc The changes to the doc tests are the ones I mentioned a while back, which were necessary to accommodate differences in the production version of data. The changes related to the new queries are in internal.py and external.py with examples of the new queries in select-datasets.md.

SFD5311 commented 3 years ago

@mccalluc Seeing tests fail on Travis, which passed locally. I will investigate and tag you once that's resolved.

SFD5311 commented 3 years ago

@mccalluc Regarding the page sizes, that's my guess, too. Doing some Postgres tuning now to see if that can address this issue without having to re-reduce the page size. Will push other changes and re-request review from you once that's done.

SFD5311 commented 3 years ago

@mccalluc I've pointed the tests at the new dedicated server which runs using a minimal test dataset. Most of the tests had to be updated accordingly. All of the tests pass now. What I've done for now is generate input for queries with other queries, rather than hardcoding a bunch of identifiers into the tests. I think this will make any future tweaks easier than the old system, but let me know if you think it's better to stick to the old way, or to switch to a config file.