search

hubmapconsortium / ingest-ui

HuBMAP Data Ingest Portal
https://ingest.hubmapconsortium.org
MIT License
4 stars 0 forks source link

Assigned to Group Name/Ingest Task Fields Missing from Uploads in Incomplete Status #1424

Closed bhonick closed 3 weeks ago

bhonick commented 2 months ago

@shirey I noticed an issue on Ingest UI. Uploads in the New status have the assigned to group name/ingest task fields visible. However, uploads in the Incomplete status do not have those controls, although the Revert toggle is present. Please see the below screenshots.

image

image

libpitt commented 1 month ago

@bhonick Just to confirm, the ask is to make the Ingest Task and Assigned To Group Name fields available and editable/writeable to the data admin, yes? And second confirmation, the Upload Title and Description fields, are these to remain uneditable in Incomplete status?

bhonick commented 1 month ago

@libpitt the Ingest Task and Assigned To Group Name are already editable/writeable by the data admins. However, the issue presented is that on Ingest UI pages like the ones displayed in the above screenshots, the UI controls for modifying those values are not present (see the first screenshot compared to the second one). I can still update those values using an API call or the bulk_update_entities DAG, but having those controls available on Ingest UI would be ideal.

libpitt commented 1 month ago

@bhonick Thanks! What I was asking is if the task is to make these fields available for edit, including the Upload Title and Description. The screen below shows what was done.

If that's okay then I'll create a PR for the change.

all-fields-editable

bhonick commented 1 month ago

@libpitt Yep, that's great, thanks!