search

hubmapconsortium / ingest-ui

HuBMAP Data Ingest Portal
https://ingest.hubmapconsortium.org
MIT License
4 stars 0 forks source link

Update `Collections.creators` field to `Collections.contributors` #1448

Closed shirey closed 4 days ago

shirey commented 2 months ago

For both Collections and EPICollections, change the field creators to contributors, do this in conjunction with https://github.com/hubmapconsortium/entity-api/issues/723

shirey commented 1 month ago

@BirdMachine When creating (POST) or updating (PUT) Collections or EPICollections that have an uploaded "contributors.tsv" file- scan the resulting contributors array and copy any entries from the contributors array to a new contacts array when the entry has contributor.is_contact == Yes (maybe search for "yes" case insensitive...even though the spec says it has to be capital "Yes").

BirdMachine commented 1 month ago

Should we also revert to rendering them in separate tables, or keep them visually joined as one and just mark contacts with the checkmark?

yuanzhou commented 2 weeks ago

image

BirdMachine commented 1 week ago

Struggling to duplicate this toLowerCase thing; Is it still happening for you @yuanzhou and could you include info on how you got there / what the logs say

yuanzhou commented 6 days ago

@BirdMachine I think you had fixed that last week. On TEST, search for Collection, then click one of the resulting records in search table. That's how I noticed that issue. If it's working now then you must have fixed that via https://github.com/hubmapconsortium/ingest-ui/pull/1484