search

hubmapconsortium / ingest-ui

HuBMAP Data Ingest Portal
https://ingest.hubmapconsortium.org
MIT License
4 stars 0 forks source link

Two spinners #603

Closed yuanzhou closed 3 years ago

yuanzhou commented 3 years ago

On both DEV and TEST. On the initial search result page load after login, I could see the dotted spinner. When I clicked the Next page arrow at the bottom, there are two spinners showing the loading status. One is the solid blue spinner on top, the other is the dotted spinner at bottom.

image

BirdMachine commented 3 years ago

was working on that, looks like the other spinner's in the Datatables. So if it hasn't loaded to the point where the Datatables is loaded (which I'm facing right now with a slow Dev response time) the UI has no indication of the current loading state. One idea is to render loading differently in the card with the Material-style top loading bar, similar toy how Youtube works in the browser. The bar avoids duplication the circle shape, but will still give some feedback that it's still working/returning data (edited)

BirdMachine commented 3 years ago

https://material.io/components/progress-indicators https://material-ui.com/components/progress/ As here, but in the card where the data table eventually loads

Screenshot from 2021-08-13 13-50-51

BirdMachine commented 3 years ago

loading

BirdMachine commented 3 years ago

Addressed in #612

yuanzhou commented 3 years ago

@BirdMachine has already addressed this issue and it's redeployed on TEST.