search

hubmapconsortium / ingest-validation-tools

HuBMAP data submission guidelines, and tools which check that submissions adhere to those guidelines.
MIT License
8 stars 18 forks source link

Change names: Level 1 assay_types "IMS positive" & "IMS negative" #283

Closed cebriggs7135 closed 4 years ago

cebriggs7135 commented 4 years ago

These should both have the prefix "MALDI_" because they describe the "maldiims" schema: https://github.com/hubmapconsortium/ingest-validation-tools/tree/master/docs/maldiims

cebriggs7135 commented 4 years ago

May reopen this because the assay is listed in Github as maldiims . But the assay_types are listed as just "IMS positive" and "IMS negative". You don't see the word "MALDI" in the metadata.tsv unless you look at instrument-assay info. Screen Shot 2020-05-25 at 5 40 03 PM

mccalluc commented 4 years ago

@cebriggs7135 : Are you waiting for more information before reopening? I just want to be sure this doesn't get lost, if it matters...

cebriggs7135 commented 4 years ago

Jeff Spraggins agrees the name of the assay_types "IMS positive" & "IMS negative" should in fact be "MALDI-IMS positive" and "MALDI-IMS negative" because there will be other IMS positive/negative assays in the future like nanoDESI-IMS, SIMS-IMS, DESI-IMS