search

hubmapconsortium / ingest-validation-tools

HuBMAP data submission guidelines, and tools which check that submissions adhere to those guidelines.
MIT License
8 stars 18 forks source link

maldiims schema appears to have changed #284

Closed cebriggs7135 closed 4 years ago

cebriggs7135 commented 4 years ago

@mccalluc Look at the metadata.tsvs for MALDI IMS & IMC. None of that text at the bottom belongs there:

https://github.com/hubmapconsortium/ingest-validation-tools/tree/master/docs/maldiims https://github.com/hubmapconsortium/ingest-validation-tools/tree/master/docs/imc

Screen Shot 2020-05-25 at 5 23 35 PM

mccalluc commented 4 years ago

@cebriggs7135 : These are the valid values for the field, and came in with PR #282, which had your approval in issue #141. The list will get shorter when it's only the types that are really valid (see PR #279).

I don't think any action is required here. Will close, but reopen if you disagree (Have second thoughts about #141, or would like a different format, etc.)

cebriggs7135 commented 4 years ago

I see. Thanks.