search

hubmapconsortium / ingest-validation-tools

HuBMAP data submission guidelines, and tools which check that submissions adhere to those guidelines.
MIT License
8 stars 18 forks source link

Mixed assay types should error? Or not? #735

Closed mccalluc closed 3 years ago

mccalluc commented 3 years ago

A single TSV could include multiple assay types:

- name: assay_type
  constraints:
    enum:
      - LC-MS (metabolomics)
      - LC-MS/MS (label-free proteomics)
      - MS (shotgun lipidomics)

but Joel writes:

This has never been done, however. All the metadata.tsv files I've seen have been for a single assay type, and in fact I'd want to watch carefully if we got one which mixed LC-MS and LC-MS/MS for example. Handling multiple separate metadata.tsv files is fully supported, however.

but then Ivan says:

Agree not a priority. But I am in a meeting with Chris Briggs and most of the PMs from the different data providers and we just said they could. So we might see this in the near future.

mccalluc commented 3 years ago

Joel says we should keep an eye on it the first time we encounter this, but should work. Closing.