hubmapconsortium / ontology-api

The HuBMAP Ontology Service
MIT License
4 stars 3 forks source link

Ontology: Rename OWLNETS-UMLS-GRAPH-12.py to reflect source of truth version of code #164

Closed AlanSimmons closed 1 year ago

AlanSimmons commented 1 year ago

Issue

In the ontology generation framework, scripts named OWLNETS-UMLS-GRAPH (aka "Jonathan's scripts") add data from the OWLNETS output of the PheKnowLator script to the base set of UMLS CSVs that are imported into an ontology neo4j.

The original script was developed as a Jupyter Notebook. The original development workflow was:

One consequence of this workflow is the presence of files with names like OWLNETS-UMLS-GRAPH-n.py. Part of the reason for this workflow is the difficulty of using Jupyter with github.

I (Alan) stopped using this workflow. The final version of the file is the one named OWLNETS-UMLS-GRAPH-12.py. This version of the script will be the source of truth that is used, especially in github. I work directly within the pure python script; Jupyter is only used for debugging.

Solution

To prevent later confusion,

  1. Rename the script.
  2. Change references to the script in build_csv.py.
AlanSimmons commented 1 year ago

This will be moved to the new UBKB repo.

AlanSimmons commented 1 year ago

This will be moved to the new UBKG repo.

AlanSimmons commented 1 year ago

Moved