Open mruffalo opened 2 years ago
I pushed a few commits to https://github.com/hubmapconsortium/portal-containers/tree/mruffalo/sprm-to-anndata-centroid-fix, but blocked on updating sprm-to-json
since this does write cell polygons in JSON format.
As far as I know, this hasn't been used by Vitessce in some time, but I'm not sure of that. Can someone who's more familiar with that code advise and/or take over? I'd hope that the additional test data and code changes in sprm-to-anndata
can be ported easily to the sprm-to-json
workflow.
(Pinged @ilan-gold on slack -- I can pick it up if he doesn't.)
@mruffalo Just to be clear here - you're saying that you want to remove the dependency on outputting polygons? I think, as I remember, removing things like this has been a no-go for already existing assays. Whether or not 3D counts as an existing assay is a different story. So for me, I think it would make sense to
Does this work for you?
Both of these workflows check for cell polygons from SPRM, for two purposes:
shapely.geometry.Polygon.centroid
*.ome.tiff-cell_polygons_spatial.csv
This is suboptimal, since this output file can be disabled via an option in SPRM, and this will not be available at all for 3D SPRM results.
This should be addressed in two ways:
*.ome.tiff-cell_centers.csv
rather than computing these in this code