hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
11 stars 2 forks source link

NickAkhmetov/CAT-677 Unified Prov Graph #3458

Closed NickAkhmetov closed 1 month ago

NickAkhmetov commented 2 months ago

This PR

Currently, this functionality is gated to datasets only.

Examples

[HBM878.HRPG.642](https://portal.hubmapconsortium.org/browse/dataset/d8f851efb54f84d7ee0952e10d4c449e) ![image](https://github.com/hubmapconsortium/portal-ui/assets/19957804/9d9ba7b4-b3e0-4573-a671-7dbbdea4329b) [HBM749.SMWP.555](https://portal.hubmapconsortium.org/browse/dataset/6df2f796ad72307d04dc94d688b725c5) ![image](https://github.com/hubmapconsortium/portal-ui/assets/19957804/3ad8af3e-f287-4d03-a143-1be0f1413134)

john-conroy commented 2 months ago

Will review shortly, but should we make the base branch a unified datasets feature branch?

NickAkhmetov commented 2 months ago

should we make the base branch a unified datasets feature branch?

My understanding was that this is a change we can roll out on all dataset pages, including the legacy views.

Should we remove the show derived entities button for dataset nodes

This question came up for me as well, I figured that it wouldn't hurt to keep it in for consistency with the donor/sample provenance graphs.