Closed NickAkhmetov closed 3 weeks ago
Thanks for the review @austenem! For transparency/clarity:
I'll convert this back into a draft for the time being and will republish the PR once it's fully functional 👍🏻
This should be ready for re-review now; the remaining changes are related to fixing broken specs, which I'll be able to fix in the morning. I'll update the PR description with all necessary documentation tomorrow as well.
Summary
This PR implements the
Processed Data
section for unified views.TODOs
Handle height difference between data products and files to avoid layout shift- since this shift only occurs on user interaction, let's leave it alone for now and correct if needed.Tooltips for status iconsI believe this was done upstream and just needs to be merged in; if not, it's a finishing touch.Future improvements not in scope of this PR
Design Documentation/Original Tickets
Subtask: https://hms-dbmi.atlassian.net/browse/CAT-777 Task: https://hms-dbmi.atlassian.net/browse/CAT-678 Designs: https://www.figma.com/design/GUz7Z37Q3AAMiRyDy7YzWd/Unified-Detail-Pages?node-id=334-42649&m=dev
Testing
See screenshots in accordions below.
Screenshots/Video
CODEX
![image](https://github.com/user-attachments/assets/c2a06dc0-8075-4be3-958d-7ca4cf39b52f)
H&E Stained Microscopy
![image](https://github.com/user-attachments/assets/cfb6938e-0789-4af1-a0eb-04417c96b1ab)
Visium
![image](https://github.com/user-attachments/assets/48c23ce8-eebc-4dee-8a73-e36b6ea82153)
Donor
![image](https://github.com/user-attachments/assets/f9c9d998-5257-401d-acca-1752ff9fbc1a)
Sample
![image](https://github.com/user-attachments/assets/970ffb51-925f-4a27-82eb-54167f2af900)
Organ
![image](https://github.com/user-attachments/assets/4f243dff-44d0-4901-96de-5be8887991a5)
Publication
![image](https://github.com/user-attachments/assets/a19152b1-91e5-499f-82f6-b69e5c5412f3)
Collapsible section demo with disappearing actions:
https://github.com/user-attachments/assets/29cf8106-0b0b-49a2-803e-bc5e5c54af73
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
I'm open to ideas re: unit tests to add.