hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
11 stars 2 forks source link

NickAkhmetov/CAT-842 Update push script to handle major version bumps #3510

Closed NickAkhmetov closed 3 weeks ago

NickAkhmetov commented 3 weeks ago

Summary

This PR updates the push.sh script to allow making major version bumps.

Major version bumps are opted into by including a second param while calling the script (e.g. ./etc/build/push.sh major). Otherwise, the previous behavior is used.

In order to account for the major version no longer being a constant 0, I had to adjust the logic for whether a patch or minor version release is made. Rather than calculating the new version tag based on a starting date in 2021, the updated logic compares the date of the last minor or major version to the current date to determine whether to make a minor or patch version bump.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-842

Testing

Manually tested by adding a die statement after the version tag was printed and attempting both major and minor version bumps.

Screenshots/Video

image

Checklist

Additional Notes

Please specify any additional information or context relevant to this PR.