This PR removes the portal UI's dependencies on the direct ancestor/descendant information available in the entity API in favor of using the corresponding ids.
Progress
ancestors
[x] Dev search used ancestors to determine raw/processed status -> revised to use processing field
[x] Prov table used ancestors to construct the table -> revised to use ancestor_ids, corresponding revisions made to error display for donors
[x] Ancestors' rui_location field is used for details_rui_json on back-end and to determine whether a dataset is spatial in the dev search
[x] Ancestors not being datasets is currently a condition for the unified prov view lookup when looking up the top level dataset -> dropped the condition in favor of using processing: raw, there should be 0..1 raw datasets in any given dataset's ancestors anyway.
descendants
Not in use.
immediate_ancestors
Mentioned in an artillery config, but otherwise not present.
immediate_descendants
useImmediateDescendantProv is used for the view derived entities button This actually uses the entity API endpoint; this can be improved to use the search API equivalent once the upstream change is made to the search API, but is not currently a blocker.
Summary
This PR removes the portal UI's dependencies on the direct ancestor/descendant information available in the entity API in favor of using the corresponding
ids
.Progress
ancestors
ancestors
to determine raw/processed status -> revised to useprocessing
fieldancestors
to construct the table -> revised to useancestor_ids
, corresponding revisions made to error display for donorsrui_location
field is used fordetails_rui_json
on back-end and to determine whether a dataset is spatial in the dev searchprocessing: raw
, there should be 0..1 raw datasets in any given dataset's ancestors anyway.descendants
immediate_ancestors
immediate_descendants
This actually uses the entity API endpoint; this can be improved to use the search API equivalent once the upstream change is made to the search API, but is not currently a blocker.useImmediateDescendantProv
is used for theview derived entities
buttonDesign Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-844
Testing
Manually verified, confirmed functionality is analogous to current production behaviors.
Screenshots/Video
Not very informative since this matches existing functionality, but for verification:
Dev search filters
![image](https://github.com/user-attachments/assets/0fbb4ee4-23d0-4a8d-8e17-8b8be0c6629b) ![image](https://github.com/user-attachments/assets/ef31a89c-505f-43ff-91af-e94ee4f63dc7) ![image](https://github.com/user-attachments/assets/4197148a-3456-453a-b9c8-86a2eef39c4b)
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.