hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
12 stars 2 forks source link

NickAkhmetov/CAT-844 Migrate away from using `descendants` and `ancestors` in favor of `id` equivalents #3515

Closed NickAkhmetov closed 2 months ago

NickAkhmetov commented 2 months ago

Summary

This PR removes the portal UI's dependencies on the direct ancestor/descendant information available in the entity API in favor of using the corresponding ids.

Progress

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-844

Testing

Manually verified, confirmed functionality is analogous to current production behaviors.

Screenshots/Video

Not very informative since this matches existing functionality, but for verification:

image

Dev search filters

![image](https://github.com/user-attachments/assets/0fbb4ee4-23d0-4a8d-8e17-8b8be0c6629b) ![image](https://github.com/user-attachments/assets/ef31a89c-505f-43ff-91af-e94ee4f63dc7) ![image](https://github.com/user-attachments/assets/4197148a-3456-453a-b9c8-86a2eef39c4b)

Checklist