After investigations related to CAT-751, Zhou and Bill have determined there is no longer any provenance information to display for donors. Historically, there were lab nodes which were showing up but did not have any related information, so they removed them approximately 4 months ago. As a result, the provenance graphs no longer had any valid relationships to display, so they crashed; therefore, removing this section in favor of the derived entities section removes an unnecessary visual component.
I have also converted the Donor detail page to TypeScript, resolved any resulting reported type errors, and updated the Protocols component to use the withShouldDisplay HOC.
[x] New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
[x] Unit tests covering the new feature have been added
[x] All existing tests pass
[x] Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
[x] Any new functionalities have appropriate analytics functionalities added
Additional Notes
I think we can probably do a lot more with the Summary section of donor pages. Right now the information there is very minimal - I think we should surface some useful information so people can learn more about the donor at a glance, e.g. demographic info, organs that were analyzed from this donor, etc.
Summary
After investigations related to CAT-751, Zhou and Bill have determined there is no longer any provenance information to display for donors. Historically, there were lab nodes which were showing up but did not have any related information, so they removed them approximately 4 months ago. As a result, the provenance graphs no longer had any valid relationships to display, so they crashed; therefore, removing this section in favor of the derived entities section removes an unnecessary visual component.
I have also converted the Donor detail page to TypeScript, resolved any resulting reported type errors, and updated the Protocols component to use the
withShouldDisplayHOC.Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-751 https://hms-dbmi.atlassian.net/browse/CAT-949
Testing
I A/B tested this donor page: https://portal.hubmapconsortium.org/browse/donor/a0bdb4249eb3a6bd1865f948875c2f96 on production and local.
Screenshots/Video
Production screenshot (Note that prod is also missing organ data in the screenshot, this was fixed in #3567)
Fixed screenshot
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
I think we can probably do a lot more with the
Summarysection of donor pages. Right now the information there is very minimal - I think we should surface some useful information so people can learn more about the donor at a glance, e.g. demographic info, organs that were analyzed from this donor, etc.