hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
12 stars 2 forks source link

Austenem/CAT-955 Fix header bug #3575

Closed austenem closed 1 month ago

austenem commented 1 month ago

Summary

Fixes a bug resulting from #3569 that caused the entity header to cut off the top of the page. This was addressed by taking a different approach to fixing the entity header bug that was resolved in #3569, which resolved both issues.

Original bug: header shifted off-screen on initial page load on narrow browser window sizes. New bug: header cut off the top of the page (due to being removed from the document flow).

Design Documentation/Original Tickets

CAT-955 Jira ticket

Testing

Tested that both bugs were resolved in Chrome and Safari.

Screenshots/Video

Original bug on prod: https://github.com/user-attachments/assets/0043111f-d370-41ad-8b1e-3c99c8344c24
Resolved original bug locally: https://github.com/user-attachments/assets/c8155da6-09ee-4d1c-8249-9b0c5326007b
Resolved new bug locally: https://github.com/user-attachments/assets/6c91cff6-2366-47b3-bae7-6375866b5e34

Checklist