Austenem/CAT-980 Fix EPIC Bulk Data Transfer sections

austenem commented 1 month ago

Summary

This update fixes the labelling on the Bulk Data Transfer table tabs for EPICs and prevents them from crashing the page when selected.

Also includes two updates to the Dataset type to make it more accurate to actual query results, and some minor accommodations for this change across the detail page.

Design Documentation/Original Tickets

CAT-980 Jira ticket

Testing

Tested using a Segmentation Mask EPIC on dev: http://localhost:5001/browse/dataset/22901da5f080b219a514e38381acbb0e?redirected=True&redirectedFromId=HBM474.PFWF.998#metadata

Screenshots/Video

Dev:

Local:

Checklist

[X] Code follows the project's coding standards
- [X] Lint checks pass locally
- [X] New CHANGELOG-your-feature-name-here.md is present in the root directory, describing the change(s) in full sentences.
[X] Unit tests covering the new feature have been added
[X] All existing tests pass
[X] Any relevant documentation in JIRA/Confluence has been updated to reflect the new feature
[X] Any new functionalities have appropriate analytics functionalities added

austenem commented 4 weeks ago

Assay_display_name being an array was meant to ease the transition from mapped_data_types which was an array to assay_display_name. Since description is not an array we could coordinate changing it back to a string.

Got it! Could you clarify what you mean by description?

john-conroy commented 4 weeks ago

description is the value we get from the soft assay endpoint to create assay_display_name during ES indexing. https://github.com/hubmapconsortium/portal-ui/pull/3581#issuecomment-2437940727.

austenem commented 4 weeks ago

description is the value we get from the soft assay endpoint to create assay_display_name during ES indexing. #3581 (comment).

Ahh thanks! This conversation slipped my mind.

hubmapconsortium / portal-ui