hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
12 stars 2 forks source link

Austenem/CAT-979 Fix EPIC table of contents #3584

Closed austenem closed 4 weeks ago

austenem commented 4 weeks ago

Summary

Fixes bug causing table of contents on EPIC detail pages to show duplicate entries and not link to the correct sections. Processed dataset sections in the table of contents are now labeled with their status if a duplicate analysis is present, and with their HuBMAP ID if both a duplicate analysis and status is present.

Design Documentation/Original Tickets

CAT-979 Jira ticket

Testing

Tested manually by checking linking for datasets with one or several processed datasets, including an EPIC dataset (HBM969.VCBV.738).

Screenshots/Video

HBM969.VCBV.738 Local: ![Screenshot 2024-10-29 at 2 16 22 PM](https://github.com/user-attachments/assets/4179a388-9059-46e2-9b76-09f2f073c93f) Dev: ![Screenshot 2024-10-29 at 2 28 27 PM](https://github.com/user-attachments/assets/a47ee52b-108e-47ba-8e13-eb551af02b04)
HBM592.JGSQ.253 Local: ![Screenshot 2024-10-29 at 2 15 57 PM](https://github.com/user-attachments/assets/6aa97cd5-1279-45cf-ad9a-7ed64655b63e) Dev: ![Screenshot 2024-10-29 at 2 28 53 PM](https://github.com/user-attachments/assets/341de7f5-98f2-43fb-8102-81ca3b67bf90)

Checklist

austenem commented 4 weeks ago

Both the bulk data section and the table of contents are consuming useProcessedDatasets and then calling processDataLabel, can we pull the logic into useProcessedDatasets for both of them? Or a new hook which wraps useProcessedDatasets might be best.

I think that's a good idea - just added a wrapper hook, let me know if that looks like what you had in mind.