hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
12 stars 2 forks source link

NickAkhmetov/CAT-736 Convert sample detail page to TSX #3592

Closed NickAkhmetov closed 3 weeks ago

NickAkhmetov commented 3 weeks ago

Summary

This PR converts the sample detail page to TypeScript. Minimal changes were necessary, as most detail page components were converted during the unified dataset detail page push.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-736

Testing

I viewed several sample pages without encountering errors.

Screenshots/Video

N/A

Checklist

Additional Notes

I wonder if we can enhance the EUI links on sample pages to link directly to the sample in question, e.g.: https://portal.hubmapconsortium.org/browse/sample/e5f2cb399e7e8885134c1b1a2b6acc9a The ccf eui link in the tissue section just takes the user to the main ccf eui page in the portal, i.e. https://portal.hubmapconsortium.org/ccf-eui; it seems like it would be a relatively straightforward enhancement for us to pass in a URL param to preselect the appropriate sample since it's not clear how one would find the sample in the EUI otherwise.