Closed NickAkhmetov closed 2 weeks ago
Looks good to me! Was there any more investigation into why the PDF is cropped?
Good catch - I didn't spot this during development since it shows up uncropped for me, but I've got a big screen. I'll improve the PDF display so it doesn't overflow the viewport.
Summary
This PR fixes the "View PDF" button disappearing while the PDF is processing. It also fixes the styles for the PDF modal's "close" button, which had a typo that caused the background of the close button to show up without a border radius.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-661
Testing
Tested manually with datasets linked in original ticket.
Screenshots/Video
View button doesn't disappear while loading anymore: https://github.com/user-attachments/assets/63bae256-bdf2-4c55-be4c-a274496c21d7
Close button has appropriate styles:
Checklist
CHANGELOG-your-feature-name-here.md
is present in the root directory, describing the change(s) in full sentences.Additional Notes
Please specify any additional information or context relevant to this PR.