hubmapconsortium / portal-ui

HuBMAP Data Portal front end
https://portal.hubmapconsortium.org
MIT License
12 stars 2 forks source link

NickAkhmetov/CAT-661 Fix View PDF button disappearance #3594

Closed NickAkhmetov closed 2 weeks ago

NickAkhmetov commented 2 weeks ago

Summary

This PR fixes the "View PDF" button disappearing while the PDF is processing. It also fixes the styles for the PDF modal's "close" button, which had a typo that caused the background of the close button to show up without a border radius.

Design Documentation/Original Tickets

https://hms-dbmi.atlassian.net/browse/CAT-661

Testing

Tested manually with datasets linked in original ticket.

Screenshots/Video

View button doesn't disappear while loading anymore: https://github.com/user-attachments/assets/63bae256-bdf2-4c55-be4c-a274496c21d7

Close button has appropriate styles: image

Checklist

Additional Notes

Please specify any additional information or context relevant to this PR.

NickAkhmetov commented 2 weeks ago

Looks good to me! Was there any more investigation into why the PDF is cropped?

Good catch - I didn't spot this during development since it shows up uncropped for me, but I've got a big screen. I'll improve the PDF display so it doesn't overflow the viewport.

image