hubmapconsortium / portal-visualization

Given HuBMAP Dataset JSON, creates a Vitessce configuration
MIT License
1 stars 1 forks source link

Eliminate unneeded conditional #56

Closed mccalluc closed 2 years ago

mccalluc commented 2 years ago

Thanks for fixing the original problem, Ilan! Here's a tweak: I've tested it with a published dataset, and the extra kwarg doesn't hurt anything:

src/vis-preview.py --url https://portal.hubmapconsortium.org/browse/dataset/c05a38c5210b870281b5aea01e290339.json

I think your original impulse was good... something like: "If an existing case is working, then let's make sure it keeps working exactly the same way"... But the downside is that adding conditionals makes the code more brittle in other ways. Each additional code path means more potential variation between runs, and more code for future maintainers to worry about.

I could be off-base... Maybe schedule a call to talk if I'm confused and this isn't going in the right direction.