hubmapconsortium / portal-visualization

Given HuBMAP Dataset JSON, creates a Vitessce configuration
MIT License
1 stars 1 forks source link

Spatial RNA-seq example doesn't work #57

Closed mccalluc closed 2 years ago

mccalluc commented 2 years ago

In anndata_builders.py:

class SpatialRNASeqAnnDataZarrViewConfBuilder(RNASeqAnnDataZarrViewConfBuilder):
    """Wrapper class for creating a AnnData-backed view configuration
    for "second generation" post-August 2020 spatial RNA-seq data from anndata-to-ui.cwl like
    https://portal.hubmapconsortium.org/browse/dataset/e65175561b4b17da5352e3837aa0e497
    """

but that example doesn't actually render as spatial... Looking at builder_factory.py:

            if "salmon_rnaseq_slideseq" in data_types:
                return SpatialRNASeqAnnDataZarrViewConfBuilder
            return RNASeqAnnDataZarrViewConfBuilder

When I look at https://portal.hubmapconsortium.org/browse/dataset/e65175561b4b17da5352e3837aa0e497.json:

      "data_types": [
        "snRNAseq"
      ],

so it's just using RNASeqAnnDataZarrViewConfBuilder instead of Spatial....

What's going on here? Some possibilities:

mccalluc commented 2 years ago

From Matt:

Currently, Slide-seq is the only sequencing spatial transcriptomics assay that we have, e.g., https://portal.hubmapconsortium.org/browse/dataset/bca0d1d7fcb2bdcde16a31d1484e83e5

I'm not sure what "second generation" means in this context though; there are two versions of some Slide-seq datasets, with versions 2 including cell type annotations from Azimuth, as in https://portal.hubmapconsortium.org/browse/dataset/2a590db3d7ab1e1512816b165d95cdcf

I think the docs can just be updated.