Closed ilan-gold closed 1 year ago
This needs to be paired with upgrading vitessce in portal-ui
a la https://github.com/hubmapconsortium/portal-ui/pull/3108
Note: this should not be merged until the data_types
issue is resolved
cc: @keller-mark for review
From Joel confirming this should work:
All derived datasets have an immediate ancestor which is another dataset. OK, modify that slightly- there exist derived datasets that have multiple datasets as immediate ancestors, in the special case of workflows that take multiple inputs. But for the image pyramids there is exactly one immediate ancestor and that is a primary dataset.
Goal To display NanoDESI datasets correctly (the difference should be quite apparent - they previously looked "squished")
Changes
use_full_resolution
/useFullResolutionImage
) to the view config because the lower resolutions of the image pyramid don't look great (at the expense of slightly slower display time)NanoDESI
so that the image gets resizedIssues
The line with the comment "very bad hack" is a problem.NanoDESI
does not appear to be in the data type key of theentity
, which it should be as far as I understand.obsSegmentation
file although this doesn't affect visualization. Will file a bug (https://github.com/vitessce/vitessce/issues/1598)To test: any of these datasets http://localhost:5001/search?mapped_data_types[0]=NanoDESI&entity_type[0]=Dataset should now display correctly (compare to prod)