hubmapconsortium / portal-visualization

Given HuBMAP Dataset JSON, creates a Vitessce configuration
MIT License
1 stars 1 forks source link

(feat): add `use_full_resolution` feature for NanoDESI #79

Closed ilan-gold closed 1 year ago

ilan-gold commented 1 year ago

Goal To display NanoDESI datasets correctly (the difference should be quite apparent - they previously looked "squished")

Changes

Issues

To test: any of these datasets http://localhost:5001/search?mapped_data_types[0]=NanoDESI&entity_type[0]=Dataset should now display correctly (compare to prod)

ilan-gold commented 1 year ago

This needs to be paired with upgrading vitessce in portal-ui a la https://github.com/hubmapconsortium/portal-ui/pull/3108

ilan-gold commented 1 year ago

Note: this should not be merged until the data_types issue is resolved

ilan-gold commented 1 year ago

cc: @keller-mark for review

ilan-gold commented 1 year ago

From Joel confirming this should work:

All derived datasets have an immediate ancestor which is another dataset.  OK, modify that slightly- there exist derived datasets that have multiple datasets as immediate ancestors, in the special case of workflows that take multiple inputs.  But for the image pyramids there is exactly one immediate ancestor and that is a primary dataset.