search

hubmapconsortium / py-hubmapbags

Python package used to build the submission for the CFDE Search Portal
1 stars 2 forks source link

Issue with dataset description on HBM749.MMKH.463 #42

Closed icaoberg closed 6 months ago

icaoberg commented 1 year ago

@j-uranic the dataset HBM749.MMKH.463 has a dataset description field that has \n and this breaks the submission. Took me a while to figure out the problem was here.

@j-uranic and @bhonick please make a decision on how to proceed

  1. Do consider this an edge case and fix code wise (please say no)
  2. Fix the issue in the database (yes!)
j-uranic commented 1 year ago

@icaoberg I am not seeing a newline in the "description" metadata field. I need the location of it to proceed with a fix. Please reply to this comment specifying between which words in the description metadata text it occurs.

icaoberg commented 1 year ago

Actually there are many like this Sent from iOS. Please excuse my brevity.

On Fri, Sep 15, 2023 at 8:14 AM j-uranic @.***> wrote:

@icaoberg https://github.com/icaoberg I am not seeing a newline in the "description" metadata field. I need the location of it to proceed with a fix. Please reply to this comment specifying between which words in the description metadata text it occurs.

— Reply to this email directly, view it on GitHub https://github.com/hubmapconsortium/py-hubmapbags/issues/42#issuecomment-1721176709, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADFAOAWJ5YEE52YRDM52ITX2RBCHANCNFSM6AAAAAA4ZCIDK4 . You are receiving this because you were mentioned.Message ID: @.***>

bhonick commented 1 year ago

It sounds like @j-uranic is working on solution #2 (thanks!). Let me know if you need anything from my end.

j-uranic commented 1 year ago

For me to proceed, I will still need to know between which words in the description metadata text it occurs. Please also include a list of the other impacted datasets with their HuBMAP IDs. Thanks.