Label issue - "No translation"

[bhonick]

Originally created by @JAH386:

The following label problem is present on the Portal.

The following datesets shows up as “no translation” on the Portal.

"2 DESI IMS in new - no change (6/27) - NO TRANSLATION label [Joel]"

[mccalluc]

There are two of these unmapped assay types that can be seen when you log in:

• Whole Transcriptome Sequencing
• DESI IMS

This error string is generated by translate.py in search-api:

def _data_types_map(ks):
    assert len(ks) == 1 or (len(ks) == 2 and ('image_pyramid' in ks or 'Image Pyramid' in ks)), \
        f"Maximum 2 types, and one should be image pyramid: {ks}"
    single_key = ks[0] if len(ks) == 1 else ks
    try:
        r = AssayType(single_key).description
    except RuntimeError:
        r = _unexpected(single_key) # <-- From here!
    return [r]

The list of assays used by AssayType comes from assay_types.yaml If entries are added there for these two, and the data is reindexed, the error will go away.

Responsibilities have shifted over time, but my sense is that the process should run something like this:

• Conversations with the TMCs around a new assay type determine whether it can share the metadata and directory schema with any existing types, or whether it is entirely new.
• ingest-validation-tools is updated accordingly, either adding new assay name to an existing schema, or creating a new schema.
• At the same time, the necessary data is gathered to fill out assay_types.yaml, in particular, contains-pii and vitessce-hints.

As far as who needs to be involved:

• I don't think I have any responsibilities in this process.
• In the past, Nils has had strong preferences about the exact assay names.
• I'm not sure if Alan is involved in working with the assay definitions in their current form, or if he is only planning for the future.
• Ilan Gold is still involved in the project on a part-time basis, and can provide information about vitessce-hints.
• I'm not sure if Brendan is covering everything else, or if you've looped in anyone else.

If this issue is useful to track the problem, feel from to keep it open, but no changes need to be made in the portal-ui code.