We are not using src/search-schema/data/definitions/fields.yaml, the portal team may still double check if portal translation relies on it for any handlings. We should refactor this out since it'll be a maintenance debt as the properties change or new ones being added.
organ_types.yaml is still being consumed by the portal code. Move to one of the UBKG calls:
GET https://ontology-api.dev.hubmapconsortium.org/organs?application_context=HUBMAP
GET https://ontology-api.dev.hubmapconsortium.org/organs/by-code?application_context=HUBMAP
tissue_sample_types.yaml is not needed, and there's no equivalent UBKG call, need to be refactored out from portal code.
data_access_levels.yaml and dataset_status_types.yaml are still tied to the portal translation code, we should add a new module inside portal directory with all the yaml value converted to constants to cater future updates.
Items have already been addressed or no longer relavant:
assay_types.yaml had been refactored out as part of the initial soft assay release.
entity_types.yaml is no longer being used.
@john-conroy you'll need to handle the transition in portal code and once all gets tested and verified, I'll obsolete them from the codebase.
yuanzhou
commented
3 weeks ago
As part of the deprecation effort to favor the new soft assay migration and also based on previous conversation: https://github.com/hubmapconsortium/search-api/pull/731
Items to be addressed:
We are not using
src/search-schema/data/definitions/fields.yaml, the portal team may still double check if portal translation relies on it for any handlings. We should refactor this out since it'll be a maintenance debt as the properties change or new ones being added.organ_types.yamlis still being consumed by the portal code. Move to one of the UBKG calls:GET https://ontology-api.dev.hubmapconsortium.org/organs?application_context=HUBMAPGET https://ontology-api.dev.hubmapconsortium.org/organs/by-code?application_context=HUBMAPtissue_sample_types.yamlis not needed, and there's no equivalent UBKG call, need to be refactored out from portal code.data_access_levels.yamlanddataset_status_types.yamlare still tied to the portal translation code, we should add a new module inside portal directory with all the yaml value converted to constants to cater future updates.Items have already been addressed or no longer relavant:
assay_types.yamlhad been refactored out as part of the initial soft assay release.entity_types.yamlis no longer being used.@john-conroy you'll need to handle the transition in portal code and once all gets tested and verified, I'll obsolete them from the codebase.