hubmapconsortium / search-api

HuBMAP search service and associated pieces to create an index
https://search.api.hubmapconsortium.org
MIT License
2 stars 2 forks source link

Remove the calculated field `index_version` #755

Open yuanzhou opened 8 months ago

yuanzhou commented 8 months ago

Currently we are adding this index_version as part of the calculated information for EACH entity document. This is totally unnecessary since this field is just the VERSION number and it doesn't reflect the actual deployment (the BUILD number) nor the actual data source (from entity-api).

https://github.com/hubmapconsortium/search-api/blob/889402736a10d44d6efb21cdfd931f398f9a4a60/src/hubmap_translator.py#L779-L783

The portal-ui uses both this index_version and their portal translation generated mapper_version (which is more accurate). So supposedly they can just stop referencing this index_version in the portal-ui and we can remove it.

https://github.com/hubmapconsortium/search-api/blob/889402736a10d44d6efb21cdfd931f398f9a4a60/src/hubmap_translation/addl_index_transformations/portal/__init__.py#L36-L47