Lchoy/fix missing sample

hubmapconsortium / search-api

HuBMAP search service and associated pieces to create an index

https://search.api.hubmapconsortium.org

MIT License

2 stars 2 forks source link

Lchoy/fix missing sample #770

Closed yuanzhou closed 5 months ago

yuanzhou commented 5 months ago

Following merged PR #767 #771 #775 for TEST

john-conroy commented 5 months ago

@lchoy what motivated the change between this and the original PR?

lchoy commented 5 months ago

@lchoy what motivated the change between this and the original PR?

Since the Portal UI is unable to handle the missing organ details, this PR changes the behavior so that the document is not added to the Portal index. Previously, the API was throwing an ArrayIndexError. Now, a message is logged to explain that this entity is invalid due to the missing data.

john-conroy commented 5 months ago

Great! I think you just need to fix the linting errors.