search

hubmapconsortium / search-api

HuBMAP search service and associated pieces to create an index
https://search.api.hubmapconsortium.org
MIT License
2 stars 2 forks source link

John conroy/yaml deps #830

Closed john-conroy closed 1 month ago

john-conroy commented 1 month ago

Fix #745.

john-conroy commented 1 month ago

@yuanzhou Looks ready to put this on DEV.

yuanzhou commented 1 month ago

@john-conroy thanks for the effort! Do you think we can also remove the yaml files at https://github.com/hubmapconsortium/search-api/tree/john-conroy/yaml-deps/src/search-schema as part of this PR?

john-conroy commented 1 month ago

@yuanzhou there are still references to the search-schema yaml files in src/libs/assay_type.py. I've deleted the yaml addressed in this PR.

AlanSimmons commented 1 month ago

@john-conroy Is there anything in particular that I should be reviewing?

yuanzhou commented 1 month ago

@yuanzhou there are still references to the search-schema yaml files in src/libs/assay_type.py. I've deleted the yaml addressed in this PR.

Thanks, @john-conroy. I'll take care of that src/libs/assay_type.py and the related pieces afterwards.

john-conroy commented 1 month ago

@AlanSimmons you were automatically tagged as reviewer because you were a code owner of the deleted yaml files.