search

hubmapconsortium / software-docs

2 stars 2 forks source link

Libpitt/101 dsg #102

Closed libpitt closed 4 months ago

libpitt commented 4 months ago

Change log:

  1. Copy SeNet Doc's src folder to mimic functionality
  2. Add data-submission-guide submodule

@tjmadonna @maxsibilla Need help with the github actions bit.

maxsibilla commented 4 months ago

@yuanzhou I have added you a reviewer as this PR does create a new method of generating a table of contents for each page (this is a new addition for the HuBMAP doc site). I have checked out various pages but its hard to determine if there is anything wrong as I am not as familiar with this site. The newest endpoint can be accessed here: http://localhost:4000/data-submission/

To test this make sure to run git submodule update --init --remote.

yuanzhou commented 4 months ago

@libpitt @maxsibilla thanks, I also requested @shirey to review after he comes back, just in case he'll have other suggestions. We can leave this PR open for now and no rush to merge.

tjmadonna commented 4 months ago

I also updated the Github Action on data-submission-guide to include hubmapconsortium/software-docs. This action sends an event to the docs repositories when data-submission-guide gets updated.

https://github.com/x-atlas-consortia/data_submission_guide/blob/main/.github/workflows/dispatch.yaml

yuanzhou commented 4 months ago

Thanks @tjmadonna, that's great!

maxsibilla commented 4 months ago

@shirey This latest commit should handle everything we discussed. See links locally: http://localhost:4000/data-submission/Section1 http://localhost:4000/assays/wgs