search

hubo / hubo-ach

Low level controller for the Hubo 2 and Hubo 2+ platforms designed by Daniel M. Lofaro. The system is based on the IPC called ACH by Neil Dantam and Mike Stilman.
Other
5 stars 18 forks source link

signConvention does not use two's complement? #50

Open ndantam opened 10 years ago

ndantam commented 10 years ago

It looks like signConvention() and DrcSignConvention converted a 24-bit two's complement signed integer to a 24-bit signed integer using a sign bit. Do the Hubo JMC's really use sign bits instead of two's complement?

robEllenberg commented 10 years ago

Yeah...we had that same facepalm moment back when we first started with jaemi. On Nov 1, 2013 12:23 AM, "Neil T. Dantam" notifications@github.com wrote:

It looks like signConvention() and DrcSignConvention converted a 24-bit two's complement signed integer to a 24-bit signed integer using a sign bit. Do the Hubo JMC's really use sign bits instead of two's complement?

— Reply to this email directly or view it on GitHubhttps://github.com/hubo/hubo-ach/issues/50 .

ndantam commented 10 years ago

Wow.

Well, that at least deserves some comments in the code.

thedancomplex commented 10 years ago

yes "facepalm" exactly.

On Fri, Nov 1, 2013 at 12:32 AM, Neil T. Dantam notifications@github.comwrote:

Wow.

Well, that at least deserves some comments in the code.

— Reply to this email directly or view it on GitHubhttps://github.com/hubo/hubo-ach/issues/50#issuecomment-27547230 .

Daniel M. Lofaro Ph.D Assistant Professor, George Mason University Electrical and Computer Engineering Department DARPA Robot Challenge Track-A Team DRC-Hubo Researcher e: dan@danLofaro.com w: http://danLofaro.com http://danlofaro.com/