search

huboard / huboard-web

GitHub issues made awesome
https://huboard.com
61 stars 26 forks source link

Accommodates custom media types #306

Closed discorick closed 8 years ago

discorick commented 8 years ago

This fixes an issue where body_html keys are not making their way to the board.

Fixes regression from https://github.com/huboard/huboard-web/pull/301

dahlbyk commented 8 years ago

I'm concerned how easy of a regression this would be to repeat. full+json is hard-code in Ghee and is otherwise invisible. We could test for it being set on request here, but there is no guarantee we won't forget next time.

We can probably merge as-is to avoid the regression on our next deploy, but I want to follow up with a solution that yields more confidence. Thoughts?

dahlbyk commented 8 years ago

More generally, GitHub API Media Types docs suggest the full+json suffix doesn't apply globally. We should definitely rethink how Ghee handles Accept headers.