huboard / huboard-web

GitHub issues made awesome
https://huboard.com
61 stars 26 forks source link

Implements references in the issue model #309

Closed discorick closed 8 years ago

discorick commented 8 years ago

Adds:

Discussion point, how much should we hydrate issues that are closed and not on the board? Currently I am returning the reference, with a state i.e

{
  url: 'https://huboard.com/huboard/huboard/issues/1'
  id: 12345,
  text: '#1'.
  state: 'closed'
}

Discovered issue references that already exist in memory are returned by their in memory counterparts (a full issue model).

related to huboard/huboard#666

dahlbyk commented 8 years ago

This is looking pretty good, but I don't think references from a linked board back to the parent board are working (e.g. https://huboard-rails-pr-309.herokuapp.com/huboard/huboard#/issues/104311313).

discorick commented 8 years ago

@dahlbyk How did you determine that? (it wont be in the payload of the issue details)

dahlbyk commented 8 years ago

How did you determine that? (it wont be in the payload of the issue details)

I set a breakpoint somewhere in the visitor, probably in discoverClosedIssue.

discorick commented 8 years ago

This is looking pretty good, but I don't think references from a linked board back to the parent board are working (e.g. https://huboard-rails-pr-309.herokuapp.com/huboard/huboard#/issues/104311313).

@dahlbyk got it here: aa0363d