huboard / huboard-web

GitHub issues made awesome
https://huboard.com
61 stars 26 forks source link

Prevents QP's from polluting others with matching name #316

Closed discorick closed 8 years ago

discorick commented 8 years ago

Problem:

An example would be a label named 'pizza' and a repo named 'pizza' - a url with query parameters to filter on the label pizza would also trigger the repo 'pizza' filter.

Solution:

The Query Parameters now only apply themselves to the filter group they belong to.

fixes https://github.com/huboard/huboard-web/issues/310

dahlbyk commented 8 years ago

Nothing to add about the code, and behavior seems correct to me: https://huboard-rails-pr-316.herokuapp.com/huboard-testing/links-label-bug#/?label=["test"]

:shipit: